BUG: (P0) lsvendor.c example does not compile out of box

[jcheng]

Descriptions:
The file is missing headers, and the example in the document uses LM_SA_USE_EXTERNAL_FILTER instead of LM_SA_USE_EXTERNAL_FILTERS. We had to correct them in order to get it to compile. (still has warnings)

--- 24,34 ----
#include
#include
#include "lm_code.h"
#include "lmclient.h"
+ #include "lm_attr.h"
+ #include "lsserver.h"
/*
* Prototypes for persistent borrow/linger
*/
static void sBorrowInit(char ** ppBuffer, int * piSize);

-Johnson

[davidz]

You say this is a P0, but it looks like you have a workaround. Are you stopped from working because of this?

[greidplatform]

This issue is not blocking testing as we figured out how to get it to work. It remains P0 as it must be corrected because it is vendor facing code which must be absolutely as straight forward as possible to adopt.

Greg

[lnielsen]

We have added the missing header file and updated the documentation. What are the warnings you are seeing?

Lars

[greidplatform]

Warning messages issued on linux (similar on Windows I believe)

lsrvend.c: In function `my_user_init_attributes':
lsrvend.c:43: warning: passing arg 4 of `lc_set_attr_vendor' makes pointer from integer without a cast

Simple casting issue which doesn't effect functionality and we didn't spend time finding the correct cast for the last parameter (1 or 0)

Greg

[greidplatform]

Confirmed fixed in the rc1 build.

Greg